Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed schedule bug #5225

Closed
wants to merge 4 commits into from
Closed

Conversation

konskov
Copy link
Contributor

@konskov konskov commented Jan 26, 2023

No description provided.

Test cases reported on gh issue
Test hour, day, week, month, year, and multiples
@konskov konskov force-pushed the fixed_schedule_bug branch from cdd895c to 09e8b47 Compare January 26, 2023 10:17
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #5225 (cdd895c) into main (684637a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head cdd895c differs from pull request most recent head 4005582. Consider uploading reports for the commit 4005582 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5225      +/-   ##
==========================================
- Coverage   89.02%   89.00%   -0.02%     
==========================================
  Files         225      225              
  Lines       51844    51845       +1     
==========================================
- Hits        46152    46143       -9     
- Misses       5692     5702      +10     
Impacted Files Coverage Δ
src/bgw/job_stat.c 92.54% <100.00%> (+0.67%) ⬆️
src/loader/bgw_launcher.c 89.51% <0.00%> (-2.55%) ⬇️
src/loader/bgw_message_queue.c 86.36% <0.00%> (-2.28%) ⬇️
tsl/src/bgw_policy/job.c 87.28% <0.00%> (-0.05%) ⬇️
tsl/src/reorder.c 86.09% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684637a...4005582. Read the comment docs.

@konskov
Copy link
Contributor Author

konskov commented Jan 26, 2023

Fixes issue reported in #5216.

Further issues:

no timezone supplied - UTC bucketing

Interval Description Status
1 day switching from winter to summer causes 1 repetition within same day --
1 week switching winter -> summer causes 1 repetition within same day --
1 month switching winter -> summer causes 1 repetition within same day --
1 year LEAP YEARS --
2 month switching winter-> summer gets out of sync, switching summer->winter causes 1 repetition within same day --
2 year LEAP YEARS --

timezone supplied - timezone aware bucketing

Interval Description Status
1 year LEAP YEARS - repetition --
2 month this gets out of sync --
2 year LEAP YEARS - repetition --

also add a function for testing more conveniently
@konskov konskov force-pushed the fixed_schedule_bug branch from 2f81576 to 4005582 Compare January 27, 2023 09:47
@konskov
Copy link
Contributor Author

konskov commented Jan 27, 2023

closing in favor of #5239

@konskov konskov closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant