Refactor tuple forming function for bulk decompression of text columns #6448
+117
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes some mechanical changes to the tuple forming function make_next_tuple(), to prepare it for the subsequent introduction of bulk decompression for text columns. It also simplifies the layout of data for the compressed columns to contain less indirections. This is important because tuple forming is a hot function that we try to keep simple.
|
@konskov, @gayyappan: please review this pull request.
|
akuzm
commented
Dec 20, 2023
Comment on lines
+13
to
+23
| /* How to obtain the decompressed datum for individual row. */ | ||
| typedef enum | ||
| { | ||
| /* For row-by-row decompression. */ | ||
| DecompressionIterator *iterator; | ||
|
|
||
| DT_Default = -2, | ||
| DT_Iterator = -1, | ||
| DT_Invalid = 0, | ||
| /* | ||
| * For bulk decompression and vectorized filters, mutually exclusive | ||
| * with the above. | ||
| * Any positive number is also valid for the decompression type. It means | ||
| * arrow array of a fixed-size by-value type, with size given by the number. | ||
| */ | ||
| ArrowArray *arrow; | ||
| } DecompressionType; |
There was a problem hiding this comment.
This will later have two new options for arrow arrays for text columns, with dictionary encoding and without.
akuzm
commented
Dec 20, 2023
Comment on lines
+173
to
+174
| /* No variable-width columns support bulk decompression. */ | ||
| Assert(false); |
There was a problem hiding this comment.
Here will be the implementation for text arrow arrays.
7 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6448 +/- ##
==========================================
- Coverage 87.33% 87.31% -0.03%
==========================================
Files 187 187
Lines 41820 41775 -45
Branches 9313 9289 -24
==========================================
- Hits 36525 36474 -51
- Misses 3623 3627 +4
- Partials 1672 1674 +2 ☔ View full report in Codecov by Sentry. |
svenklemm
approved these changes
Dec 20, 2023
antekresic
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes some mechanical changes to the tuple forming function make_next_tuple(), to prepare it for the subsequent introduction of bulk decompression for text columns. It also simplifies the layout of data for the compressed columns to contain less indirections. This is important because tuple forming is a hot function that we try to keep simple.
Disable-check: force-changelog-file