Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UBSan failure in bulk text decompression #6583

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 31, 2024

Fix missing alignment handling, and also buffer size problems. We were not properly reporting the failures in the compression_algo tests, so didn't notice these problems. Add part of tests from "vector text predicates" PR to improve coverage.

https://github.com/timescale/timescaledb/actions/runs/7726479796/job/21064729212

Disable-check: force-changelog-file

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (1502bad) 79.82% compared to head (252cd98) 79.78%.
Report is 4 commits behind head on main.

Files Patch % Lines
tsl/src/compression/array.c 45.45% 0 Missing and 6 partials ⚠️
tsl/test/src/decompress_arithmetic_test_impl.c 16.66% 3 Missing and 2 partials ⚠️
tsl/test/src/decompress_text_test_impl.c 16.66% 3 Missing and 2 partials ⚠️
tsl/src/compression/dictionary.c 0.00% 0 Missing and 1 partial ⚠️
tsl/src/compression/simple8b_rle_decompress_all.h 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6583      +/-   ##
==========================================
- Coverage   79.82%   79.78%   -0.04%     
==========================================
  Files         190      190              
  Lines       37148    37237      +89     
  Branches     9419     9441      +22     
==========================================
+ Hits        29652    29711      +59     
- Misses       3114     3137      +23     
- Partials     4382     4389       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm added this to the TimescaleDB 2.14 milestone Jan 31, 2024
@akuzm akuzm mentioned this pull request Jan 31, 2024
7 tasks
@akuzm akuzm marked this pull request as ready for review February 1, 2024 09:54
@github-actions github-actions bot requested review from mahipv and mkindahl February 1, 2024 10:00
Copy link

github-actions bot commented Feb 1, 2024

@mahipv, @mkindahl: please review this pull request.

Powered by pull-review

.github/workflows/sanitizer-build-and-test.yaml Outdated Show resolved Hide resolved
scripts/upload_ci_stats.sh Outdated Show resolved Hide resolved
Fix missing alignment handling, and also buffer size problems. We were
not properly reporting the failures in the compression_algo tests, so
didn't notice these problems. Add part of tests from "vector text
predicates" PR to improve coverage.
@akuzm akuzm enabled auto-merge (rebase) February 1, 2024 13:07
@akuzm akuzm merged commit d7239f3 into timescale:main Feb 1, 2024
61 of 63 checks passed
@akuzm akuzm deleted the sanitizer branch February 1, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants