Fix update script for tables with dropped columns #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@konskov, @mahipv: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6636 +/- ##
==========================================
- Coverage 79.99% 79.99% -0.01%
==========================================
Files 190 190
Lines 37217 37167 -50
Branches 9457 9436 -21
==========================================
- Hits 29773 29730 -43
- Misses 3032 3040 +8
+ Partials 4412 4397 -15 ☔ View full report in Codecov by Sentry. |
akuzm
approved these changes
Feb 12, 2024
konskov
approved these changes
Feb 12, 2024
|
Surprising that we don't have a table with dropped column in the upgrade tests, might be good to add. |
svenklemm
force-pushed
the
compression_update
branch
from
d4862e4 to
2be9576
Compare
I added a test table with this configuration. |
svenklemm
force-pushed
the
compression_update
branch
5 times, most recently
from
8182d68 to
e7d57de
Compare
svenklemm
force-pushed
the
compression_update
branch
from
e7d57de to
79f2733
Compare
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#6630 Add views for per chunk compression settings **Bugfixes** * timescale#6636 Fixes extension update of compressed hypertables with dropped columns * timescale#6637 Reset sequence numbers on non-rollup compression * timescale#6639 Disable default indexscan for compression * timescale#6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm
added a commit
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #6630 Add views for per chunk compression settings **Bugfixes** * #6636 Fixes extension update of compressed hypertables with dropped columns * #6637 Reset sequence numbers on non-rollup compression * #6639 Disable default indexscan for compression * #6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm
added a commit
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #6630 Add views for per chunk compression settings **Bugfixes** * #6636 Fixes extension update of compressed hypertables with dropped columns * #6637 Reset sequence numbers on non-rollup compression * #6639 Disable default indexscan for compression * #6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
svenklemm
added a commit
that referenced
this pull request
Feb 14, 2024
This release contains bug fixes since the 2.14.0 release. We recommend that you upgrade at the next available opportunity. **Features** * #6630 Add views for per chunk compression settings **Bugfixes** * #6636 Fixes extension update of compressed hypertables with dropped columns * #6637 Reset sequence numbers on non-rollup compression * #6639 Disable default indexscan for compression * #6651 Fix DecompressChunk path generation with per chunk settings **Thanks** * @anajavi for reporting an issue with extension update of compressed hypertables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6633