Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly determine relation type of OSM chunk as standalone table #6840

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Apr 18, 2024

Previously we only handled the case of OSM chunk expanded as a child of hypertable, so in the case of direct select it segfaulted while trying to access an fdw_private which is managed by OSM.

Disable-check: force-changelog-file

Previously we only handled the case of OSM chunk expanded as a child of
hypertable, so in the case of direct select it segfaulted while trying
to access an fdw_private which is managed by OSM.
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (59f50f2) to head (e522b72).
Report is 113 commits behind head on main.

❗ Current head e522b72 differs from pull request most recent head cd6a741. Consider uploading reports for the commit cd6a741 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6840      +/-   ##
==========================================
+ Coverage   80.06%   80.87%   +0.81%     
==========================================
  Files         190      197       +7     
  Lines       37181    37026     -155     
  Branches     9450     9667     +217     
==========================================
+ Hits        29770    29946     +176     
- Misses       2997     3215     +218     
+ Partials     4414     3865     -549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jnidzwetzki jnidzwetzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we could introduce a dummy entry in the catalog to get better test coverage for this kind of chunks. However, this might be out-of-scope of this PR.

@akuzm
Copy link
Member Author

akuzm commented Apr 18, 2024

I am wondering if we could introduce a dummy entry in the catalog to get better test coverage for this kind of chunks. However, this might be out-of-scope of this PR.

We do have a test for this that uses postgres_fdw as a kind of OSM chunk replacement. Just added a couple of test cases there.

@akuzm akuzm added this to the TimescaleDB 2.15.0 milestone Apr 18, 2024
@akuzm akuzm enabled auto-merge (squash) April 18, 2024 18:54
@akuzm akuzm merged commit 069ccbe into timescale:main Apr 18, 2024
38 of 39 checks passed
@akuzm akuzm deleted the osm-standalone-chunk branch April 18, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants