Fix segfault on non-open primary dimension when compressing #6978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6978 +/- ##
==========================================
+ Coverage 80.06% 81.72% +1.66%
==========================================
Files 190 199 +9
Lines 37181 36936 -245
Branches 9450 9651 +201
==========================================
+ Hits 29770 30187 +417
+ Misses 2997 2870 -127
+ Partials 4414 3879 -535 ☔ View full report in Codecov by Sentry. |
JamesGuthrie
requested changes
May 31, 2024
JamesGuthrie
approved these changes
May 31, 2024
fabriziomello
approved these changes
May 31, 2024
svenklemm
force-pushed
the
closed_primary
branch
2 times, most recently
from
4eabe68
to
85a9a3e
Compare
With the new hypertable API hypertables can be created with primary space partition. In dev-builds this was prevented with Asserts. This patch removes the Asserts and adds a proper check.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Jun 6, 2024
This release contains performance improvements and bug fixes since the 2.15.0 release. Best practice is to upgrade at the next available opportunity. **Migrating from self-hosted TimescaleDB v2.14.x and earlier** After you run `ALTER EXTENSION`, you must run [this SQL script](https://github.com/timescale/timescaledb-extras/blob/master/utils/2.15.X-fix_hypertable_foreign_keys.sql). For more details, see the following pull request [timescale#6797](timescale#6797). If you are migrating from TimescaleDB v2.15.0 or v2.15.1, no changes are required. **Bugfixes** * timescale#6975: Fix sort pushdown for partially compressed chunks. * timescale#6976: Fix removal of metadata function and update script. * timescale#6978: Fix segfault in compress_chunk with primary space partition. * timescale#6993: Disallow hash partitioning on primary column. **Thanks** * @gugu for reporting the issue with catalog corruption due to update. * @srieding for reporting an issue with partially compressed chunks and ordering on joined columns.
Merged
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Jun 6, 2024
This release contains performance improvements and bug fixes since the 2.15.0 release. Best practice is to upgrade at the next available opportunity. **Migrating from self-hosted TimescaleDB v2.14.x and earlier** After you run `ALTER EXTENSION`, you must run [this SQL script](https://github.com/timescale/timescaledb-extras/blob/master/utils/2.15.X-fix_hypertable_foreign_keys.sql). For more details, see the following pull request [timescale#6797](timescale#6797). If you are migrating from TimescaleDB v2.15.0 or v2.15.1, no changes are required. **Bugfixes** * timescale#6975: Fix sort pushdown for partially compressed chunks. * timescale#6976: Fix removal of metadata function and update script. * timescale#6978: Fix segfault in compress_chunk with primary space partition. * timescale#6993: Disallow hash partitioning on primary column. **Thanks** * @gugu for reporting the issue with catalog corruption due to update. * @srieding for reporting an issue with partially compressed chunks and ordering on joined columns.
pallavisontakke
added a commit
to pallavisontakke/timescaledb
that referenced
this pull request
Jun 7, 2024
This release contains performance improvements and bug fixes since the 2.15.1 release. Best practice is to upgrade at the next available opportunity. **Bugfixes** * timescale#6975: Fix sort pushdown for partially compressed chunks. * timescale#6976: Fix removal of metadata function and the update script. * timescale#6978: Fix segfault in compress_chunk with primary space partition. * timescale#6993: Disallow hash partitioning on the primary column. **Thanks** * @gugu for reporting the issue with catalog corruption due to update. * @srieding for reporting the issue with partially compressed chunks and ordering on joined columns.
Merged
pallavisontakke
added a commit
that referenced
this pull request
Jun 7, 2024
This release contains bug fixes since the 2.15.1 release. Best practice is to upgrade at the next available opportunity. **Bugfixes** * #6975: Fix sort pushdown for partially compressed chunks. * #6976: Fix removal of metadata function and the update script. * #6978: Fix segfault in `compress_chunk` with primary space partition. * #6993: Disallow hash partitioning on the primary column. **Thanks** * @gugu for reporting the issue with catalog corruption due to update. * @srieding for reporting the issue with partially compressed chunks and ordering on joined columns.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Jun 7, 2024
This release contains performance improvements and bug fixes since the 2.15.0 release. Best practice is to upgrade at the next available opportunity. **Migrating from self-hosted TimescaleDB v2.14.x and earlier** After you run `ALTER EXTENSION`, you must run [this SQL script](https://github.com/timescale/timescaledb-extras/blob/master/utils/2.15.X-fix_hypertable_foreign_keys.sql). For more details, see the following pull request [timescale#6797](timescale#6797). If you are migrating from TimescaleDB v2.15.0 or v2.15.1, no changes are required. **Bugfixes** * timescale#6975: Fix sort pushdown for partially compressed chunks. * timescale#6976: Fix removal of metadata function and update script. * timescale#6978: Fix segfault in compress_chunk with primary space partition. * timescale#6993: Disallow hash partitioning on primary column. **Thanks** * @gugu for reporting the issue with catalog corruption due to update. * @srieding for reporting an issue with partially compressed chunks and ordering on joined columns.
fabriziomello
added a commit
that referenced
this pull request
Jun 7, 2024
This release contains performance improvements and bug fixes since the 2.15.0 release. Best practice is to upgrade at the next available opportunity. **Migrating from self-hosted TimescaleDB v2.14.x and earlier** After you run `ALTER EXTENSION`, you must run [this SQL script](https://github.com/timescale/timescaledb-extras/blob/master/utils/2.15.X-fix_hypertable_foreign_keys.sql). For more details, see the following pull request [#6797](#6797). If you are migrating from TimescaleDB v2.15.0 or v2.15.1, no changes are required. **Bugfixes** * #6975: Fix sort pushdown for partially compressed chunks. * #6976: Fix removal of metadata function and update script. * #6978: Fix segfault in compress_chunk with primary space partition. * #6993: Disallow hash partitioning on primary column. **Thanks** * @gugu for reporting the issue with catalog corruption due to update. * @srieding for reporting an issue with partially compressed chunks and ordering on joined columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new hypertable API hypertables can be created with primary space partition. In dev-builds this was prevented with Asserts. This patch removes the Asserts and adds a proper check.
Fixes #6977