Fix removal of metadata function and update script #6996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
force-pushed
the
fix-remove-metadata
branch
from
aeb56fe
to
e687130
Compare
antekresic
force-pushed
the
fix-remove-metadata
branch
from
e687130
to
4f16d54
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6996 +/- ##
==========================================
+ Coverage 80.06% 81.75% +1.68%
==========================================
Files 190 199 +9
Lines 37181 37015 -166
Branches 9450 9673 +223
==========================================
+ Hits 29770 30261 +491
+ Misses 2997 2863 -134
+ Partials 4414 3891 -523 ☔ View full report in Codecov by Sentry. |
svenklemm
reviewed
Jun 4, 2024
svenklemm
approved these changes
Jun 4, 2024
fabriziomello
approved these changes
Jun 5, 2024
antekresic
force-pushed
the
fix-remove-metadata
branch
2 times, most recently
from
1a482a9
to
7a24acc
Compare
svenklemm
approved these changes
Jun 5, 2024
antekresic
force-pushed
the
fix-remove-metadata
branch
from
7a24acc
to
e58f737
Compare
Changing the code to remove the assumption of 1:1 mapping between chunks and chunk constraints. Including a check if a chunk constraint is shared with another chunk. In that case, skip deleting the dimension slice.
antekresic
force-pushed
the
fix-remove-metadata
branch
from
e58f737
to
5a3eb80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the code to remove the assumption of 1:1
mapping between chunks and chunk constraints. Including
a check if a chunk constraint is shared with another chunk.
In that case, skip deleting the dimension slice.
Fixes #6976
Disable-check: force-changelog-file