-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax some JOIN restrictions on CAggs #7032
Relax some JOIN restrictions on CAggs #7032
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7032 +/- ##
==========================================
+ Coverage 80.06% 81.79% +1.72%
==========================================
Files 190 202 +12
Lines 37181 37355 +174
Branches 9450 9741 +291
==========================================
+ Hits 29770 30555 +785
+ Misses 2997 2891 -106
+ Partials 4414 3909 -505 ☔ View full report in Codecov by Sentry. |
762e673
to
0e09a0e
Compare
Why are we not just allowing this? |
We will and it will be part of Q3, but for now I just want make sure it will not segfault. |
0e09a0e
to
c20262c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please describe why the segfault occurs and how it was fixed in the commit comment?
c20262c
to
56117dc
Compare
Done! |
e3d51f6
to
79bd882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still segfaults with following query:
CREATE MATERIALIZED VIEW cagg1 with(timescaledb.continuous) as select time_bucket('1d',time) from metrics m1 join metrics m2 using(time) join metrics m3 using(time) group by 1;
79bd882
to
f200ed7
Compare
Actually it is failing on 151388 (leader) fabrizio=# CREATE MATERIALIZED VIEW cagg1 with(timescaledb.continuous) as select time_bucket('1d',time) from metrics m1 join metrics m2 using(time) join metrics m3 using(time) group by 1;
NOTICE: 00000: continuous aggregate "cagg1" is already up-to-date
LOCATION: emit_up_to_date_notice, refresh.c:674
CREATE MATERIALIZED VIEW
Time: 32,843 ms |
@svenklemm I'll rewrite all this messy join validation... it can be way simpler!!! |
It probably takes the same amount of time to change the code to allow it, so why not just do that? |
f200ed7
to
2206a22
Compare
Changed the original PR direction
1396ea5
to
6e72d99
Compare
6e72d99
to
c04ba6f
Compare
c04ba6f
to
b90b464
Compare
Remove some Continuous Aggregates JOIN restrictions by allowing: * INNER/LEFT join * LATERAL join * Join between 1 hypertable and N regular tables or materialized views * Remove restriction of only ONE equality operator on JOIN clause
b90b464
to
9ee1480
Compare
Relax JOIN restrictions on CAggs by allowing
Closes #1446, #1516, #1717, #2400, #3314, #4088
Disable-check: force-changelog-file