Relax some JOIN restrictions on CAggs

[fabriziomello]

Relax JOIN restrictions on CAggs by allowing

• INNER/LEFT join
• LATERAL join
• Join between 1 hypertable and N regular tables or materialized views
• Remove restriction of only ONE equality operator on JOIN clause

Closes #1446, #1516, #1717, #2400, #3314, #4088

Disable-check: force-changelog-file

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.79%. Comparing base (59f50f2) to head (b90b464).
Report is 245 commits behind head on main.

Files	Patch %	Lines
tsl/src/continuous_aggs/common.c	81.81%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7032      +/-   ##
==========================================
+ Coverage   80.06%   81.79%   +1.72%     
==========================================
  Files         190      202      +12     
  Lines       37181    37355     +174     
  Branches     9450     9741     +291     
==========================================
+ Hits        29770    30555     +785     
+ Misses       2997     2891     -106     
+ Partials     4414     3909     -505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[svenklemm]

Why are we not just allowing this?

[fabriziomello]

Why are we not just allowing this?

We will and it will be part of Q3, but for now I just want make sure it will not segfault.

[mkindahl]

Could you please describe why the segfault occurs and how it was fixed in the commit comment?

[fabriziomello]

Could you please describe why the segfault occurs and how it was fixed in the commit comment?

Done!

[svenklemm]

Still segfaults with following query:
CREATE MATERIALIZED VIEW cagg1 with(timescaledb.continuous) as select time_bucket('1d',time) from metrics m1 join metrics m2 using(time) join metrics m3 using(time) group by 1;

[fabriziomello]

Still segfaults with following query: CREATE MATERIALIZED VIEW cagg1 with(timescaledb.continuous) as select time_bucket('1d',time) from metrics m1 join metrics m2 using(time) join metrics m3 using(time) group by 1;

Actually it is failing on main with my patch is even works... it is allowing it :-(

151388 (leader) fabrizio=# CREATE MATERIALIZED VIEW cagg1 with(timescaledb.continuous) as select time_bucket('1d',time) from metrics m1 join metrics m2 using(time) join metrics m3 using(time) group by 1;
NOTICE:  00000: continuous aggregate "cagg1" is already up-to-date
LOCATION:  emit_up_to_date_notice, refresh.c:674
CREATE MATERIALIZED VIEW
Time: 32,843 ms

[fabriziomello]

@svenklemm I'll rewrite all this messy join validation... it can be way simpler!!!

[svenklemm]

It probably takes the same amount of time to change the code to allow it, so why not just do that?

Changed the original PR direction