Relax CAggs JOIN restrictions #7111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
continuous_aggregate
enhancement
fabriziomello
force-pushed
the
cagg_relax_join_restrictions
branch
from
9ee1480
to
658deaa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7111 +/- ##
==========================================
+ Coverage 80.06% 81.80% +1.73%
==========================================
Files 190 203 +13
Lines 37181 38035 +854
Branches 9450 9872 +422
==========================================
+ Hits 29770 31115 +1345
+ Misses 2997 2961 -36
+ Partials 4414 3959 -455 ☔ View full report in Codecov by Sentry. |
svenklemm
reviewed
Jul 8, 2024
svenklemm
reviewed
Jul 8, 2024
fabriziomello
force-pushed
the
cagg_relax_join_restrictions
branch
from
3cc8ea8
to
d7fb0bd
Compare
svenklemm
approved these changes
Jul 10, 2024
fabriziomello
force-pushed
the
cagg_relax_join_restrictions
branch
2 times, most recently
from
7273d9d
to
3d4a741
Compare
Remove some Continuous Aggregates JOIN restrictions by allowing: * INNER/LEFT join; * LATERAL join; * JOIN between 1 hypertable and N tables, foreign tables, views or materialized views; * Remove restriction of only ONE equality operator on JOIN clause.
fabriziomello
force-pushed
the
cagg_relax_join_restrictions
branch
from
3d4a741
to
1b62a3f
Compare
akuzm
approved these changes
Jul 16, 2024
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Jul 22, 2024
Creating or changing to realtime a Continuous Aggregate with multiple joins was leading to a segfault. Fixed it by dealing properly with the `varno` when creating the `Quals` for the union view in realtime mode. Also get rid of some left over when we relaxed the CAggs joint restrictions in timescale#7111
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Jul 22, 2024
Creating or changing to realtime a Continuous Aggregate with multiple joins was leading to a segfault. Fixed it by dealing properly with the `varno` when creating the `Quals` for the union view in realtime mode. Also get rid of some left over when we relaxed the CAggs joint restrictions in timescale#7111
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Jul 23, 2024
Creating or changing to realtime a Continuous Aggregate with multiple joins was leading to a segfault. Fixed it by dealing properly with the `varno` when creating the `Quals` for the union view in realtime mode. Also get rid of some left over when we relaxed the CAggs join restrictions in timescale#7111.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Jul 23, 2024
Creating or changing to realtime a Continuous Aggregate with multiple joins was leading to a segfault. Fixed it by dealing properly with the `varno` when creating the `Quals` for the union view in realtime mode. Also get rid of some left over when we relaxed the CAggs join restrictions in timescale#7111.
fabriziomello
added a commit
that referenced
this pull request
Jul 23, 2024
Creating or changing to realtime a Continuous Aggregate with multiple joins was leading to a segfault. Fixed it by dealing properly with the `varno` when creating the `Quals` for the union view in realtime mode. Also get rid of some left over when we relaxed the CAggs join restrictions in #7111.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some Continuous Aggregates JOIN restrictions by allowing:
materialized views;
Closes #1446, #1516, #1717, #2400, #3314, #4088, #7107
Disable-check: force-changelog-file