Fix enable_job_execution_logging GUC context
#7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
bug
bgw
akuzm
approved these changes
Jul 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7131 +/- ##
==========================================
+ Coverage 80.06% 81.77% +1.70%
==========================================
Files 190 203 +13
Lines 37181 38035 +854
Branches 9450 9872 +422
==========================================
+ Hits 29770 31102 +1332
+ Misses 2997 2969 -28
+ Partials 4414 3964 -450 ☔ View full report in Codecov by Sentry. |
In timescale#6767 we allowed users to track job execution history by turning on the new GUC `timescaledb.enable_job_execution_logging`. Unfortunately we defined this GUC as PGC_USERSET context but the right context should be PGC_SIGHUP since it won't work when setting at session and/or database level so we should restrict it to be used only by `ALTER SYSTEM SET` or changing the config files.
fabriziomello
force-pushed
the
fix_enable_job_execution_logging_guc_context
branch
from
49aeccb
to
3b56df8
Compare
antekresic
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6767 we allowed users to track job execution history by turning on the new GUC
timescaledb.enable_job_execution_logging.Unfortunately we defined this GUC as PGC_USERSET context but the right context should be PGC_SIGHUP since it won't work when setting at session and/or database level so we should restrict it to be used only by
ALTER SYSTEM SETor changing the config files.Disable-check: force-changelog-file