-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move chunkwise aggregation into TSL part #7159
Conversation
Its purpose is to enable vectorized aggregation, and it has to interact with DecompressChunk to build proper plans, both of which are TSL-only.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7159 +/- ##
==========================================
+ Coverage 80.06% 81.70% +1.63%
==========================================
Files 190 204 +14
Lines 37181 38015 +834
Branches 9450 9855 +405
==========================================
+ Hits 29770 31060 +1290
+ Misses 2997 2985 -12
+ Partials 4414 3970 -444 ☔ View full report in Codecov by Sentry. |
There are quite a few test changes where we no longer push down aggregates |
Right, the Apache ones. I think it's OK, the purpose of implementing our own partitionwise aggregation was to support vectorized aggregation which is TSL-only anyway. And if people need chunkwise aggregation with Apache version, there is the standard PG option |
dont think enable_partitionwise_aggregate works anymore for hypertables |
Its purpose is to enable vectorized aggregation, and it has to interact with DecompressChunk to build proper plans, both of which are TSL-only.
Disable-check: force-changelog-file