Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for RETURNING clause for MERGE #7275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpan2034
Copy link
Contributor

This adds Timescale support for the RETURNING clause with MERGE statements, which was added in PG17.

@kpan2034 kpan2034 added the pg17 label Sep 17, 2024
@kpan2034 kpan2034 self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 60.24096% with 33 lines in your changes missing coverage. Please review.

Project coverage is 92.25%. Comparing base (59f50f2) to head (1698c74).
Report is 346 commits behind head on main.

Files with missing lines Patch % Lines
src/import/ht_hypertable_modify.c 67.92% 17 Missing ⚠️
src/nodes/hypertable_modify.c 46.66% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7275       +/-   ##
===========================================
+ Coverage   80.06%   92.25%   +12.19%     
===========================================
  Files         190      205       +15     
  Lines       37181    38497     +1316     
  Branches     9450     9984      +534     
===========================================
+ Hits        29770    35517     +5747     
+ Misses       2997     2980       -17     
+ Partials     4414        0     -4414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpan2034 kpan2034 force-pushed the returning-support branch 3 times, most recently from edf049a to 5000661 Compare September 17, 2024 22:16
@svenklemm svenklemm added this to the TimescaleDB 2.17.0 milestone Sep 18, 2024
This adds support for the RETURNING clause with MERGE
statements, which was added in PG17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants