Vectorized aggregation with grouping by one fixed-size column #7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7341 +/- ##
==========================================
+ Coverage 80.06% 82.27% +2.21%
==========================================
Files 190 237 +47
Lines 37181 43668 +6487
Branches 9450 10957 +1507
==========================================
+ Hits 29770 35930 +6160
- Misses 2997 3403 +406
+ Partials 4414 4335 -79 ☔ View full report in Codecov by Sentry. |
erimatnor
approved these changes
Dec 18, 2024
tsl/src/nodes/vector_agg/exec.c
Outdated
| } | ||
| } | ||
|
|
||
| /* | ||
| * Currently the only grouping policy we use is per-batch grouping. | ||
| * Determine which grouping policy we are going to use. |
There was a problem hiding this comment.
Out of curiosity: Why is the grouping policy decided at execution time and not plan time? Should it not affect the plan and cost calc?
There was a problem hiding this comment.
I moved it all to plan time, although as we discussed today on call, it doesn't affect the costs yet.
Co-authored-by: Erik Nordström <819732+erimatnor@users.noreply.github.com> Signed-off-by: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com>
Co-authored-by: Erik Nordström <819732+erimatnor@users.noreply.github.com> Signed-off-by: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation uses the Postgres simplehash hash table for by-value fixed-size compressed columns.
The biggest improvement on a "sensible" query is about 90%, and a couple of queries show bigger improvements but these are very synthetic cases that don't make much sense:
https://grafana.ops.savannah-dev.timescale.com/d/fasYic_4z/compare-akuzm?orgId=1&var-branch=All&var-run1=3815&var-run2=3816&var-threshold=0.02&var-use_historical_thresholds=true&var-threshold_expression=2%20%2A%20percentile_cont%280.90%29&var-exact_suite_version=false&from=now-2d&to=now