Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brief explain stats #7355

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Oct 17, 2024

Use a more compact and easy to read version for the decompression and arrow array cache stats and simplify the code.

The style is copied from the style for showing Buffer information in standard PostgreSQL.

Disable-check: force-changelog-file

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.18%. Comparing base (59f50f2) to head (9406c69).
Report is 658 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/hypercore/arrow_cache_explain.c 90.32% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7355      +/-   ##
==========================================
+ Coverage   80.06%   82.18%   +2.11%     
==========================================
  Files         190      230      +40     
  Lines       37181    43321    +6140     
  Branches     9450    10893    +1443     
==========================================
+ Hits        29770    35603    +5833     
- Misses       2997     3399     +402     
+ Partials     4414     4319      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkindahl mkindahl marked this pull request as ready for review October 17, 2024 06:30
@mkindahl mkindahl self-assigned this Oct 17, 2024
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch 2 times, most recently from bf29758 to 8f68c55 Compare October 19, 2024 11:24
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch from 8f68c55 to dbf3262 Compare October 29, 2024 07:39
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch 2 times, most recently from 4d48cfb to 8262b48 Compare November 22, 2024 09:22
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch 2 times, most recently from cf8ce07 to 675f2f4 Compare November 22, 2024 14:46
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch 7 times, most recently from 75d6573 to ed37473 Compare November 29, 2024 06:38
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch from ed37473 to d323ce3 Compare December 3, 2024 15:38
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch from d323ce3 to 22483e1 Compare December 16, 2024 16:07
Use a more compact and easy to read version for the decompression and
arrow array cache stats. Also simplify the code and the tests to remove
unnecessary parts.
@mkindahl mkindahl force-pushed the hypercore-brief-array-stats branch from 22483e1 to 9406c69 Compare December 16, 2024 16:09
@mkindahl mkindahl merged commit 1a43266 into timescale:main Dec 17, 2024
46 checks passed
@mkindahl mkindahl deleted the hypercore-brief-array-stats branch December 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants