Fix flaky reorder regression test take 2 #7538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkindahl, @antekresic: please review this pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7538 +/- ##
==========================================
+ Coverage 80.06% 82.16% +2.09%
==========================================
Files 190 230 +40
Lines 37181 43280 +6099
Branches 9450 10882 +1432
==========================================
+ Hits 29770 35559 +5789
- Misses 2997 3399 +402
+ Partials 4414 4322 -92 ☔ View full report in Codecov by Sentry. |
mkindahl
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
If you want you can reduce the min messages to WARNING in the move test, since that is not relevant for the test.
For the other cases I agree that the informational messages needs to be printed (to show progress of the operation), and that the "rebuild table" information is not necessary for the tests, so approving.
fabriziomello
force-pushed
the
fix_flaky_reorder_take2
branch
2 times, most recently
from
14dfbc2 to
3a4bca6
Compare
In timescale#7509 we added manual VACUUM in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're removing the output `found 0 removable, 0 nonremovable row versions in 0 pages` to have a more predictable output test. https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
fabriziomello
force-pushed
the
fix_flaky_reorder_take2
branch
from
3a4bca6 to
74de124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7509 we added manual VACUUM in all involved relations to avoid flaky output tests.
But looks like it is not working very well specially on Windows builds, so now we're removing the output
found 0 removable, 0 nonremovable row versions in 0 pagesto have a more predictable output test.https://github.com/timescale/timescaledb/actions/runs/12322325859/job/34395659212?pr=7533#step:17:24
Disable-check: force-changelog-file
Disable-check: approval-count