Look through SSAValue to find include
#869
Conversation
There's no guarantee that all include calls will be literal GlobalRefs and in fact JuliaLang/julia#56746 will likely make them never GlobalRef.
Keno
force-pushed
the
kf/ssalookthrough
branch
from
687c7d5 to
a2943da
Compare
|
Nightly CI failure will be JuliaLang/julia#56756 |
| while isa(f, Core.SSAValue) || isa(f, JuliaInterpreter.SSAValue) | ||
| f = code[f.id] | ||
| end |
There was a problem hiding this comment.
We have quite a bit of similar code in JuliaInterpreter and LoweredCodeUtils, so it might be a good idea to consolidate it into a single utility.
Other code typically doesn’t use while like this but instead only follows a single level of SSAValue references. I’ll handle the refactoring later.
There was a problem hiding this comment.
There's lots of hacks all over the place. I think we need to take a much wider look at refactoring this stack next year, probably once JuliaLowering is ready. It's just all way too ad hoc and fragile
There was a problem hiding this comment.
Yeah overhauling the whole stack at once with integrating JuliaLowering would be very reasonable.
There's no guarantee that all include calls will be literal GlobalRefs and in fact JuliaLang/julia#56746 will likely make them never GlobalRef.