Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package directories should have README/LICENSE files #106

Closed
pfitzseb opened this issue Jun 24, 2020 · 2 comments
Closed

Package directories should have README/LICENSE files #106

pfitzseb opened this issue Jun 24, 2020 · 2 comments

Comments

@pfitzseb
Copy link

Pkg.jl only downloads the package directory, not the whole git repo. This means that you won't have a license or readme locally after pkg> add SnoppCompileCore:

λ tree SnoopCompileCore       
SnoopCompileCore
└── uT7Ty
    ├── Project.toml
    └── src
        ├── snoopc.jl
        ├── SnoopCompileCore.jl
        ├── snoopi.jl
        └── snoopr.jl

It's possible that this can be fixed on the Pkg (or package server) side, but for now it'd probably be best to have symlinks/copies in each package dir.

@KristofferC
Copy link
Collaborator

Yes, it is important to understand that each package in this repo is just a normal package. The way things are structured now makes them more similar to submodules.

@timholy
Copy link
Owner

timholy commented Jun 24, 2020

Yeah, I've realized that what I actually want is the ability to load specific submodules from a package without loading the whole package. The recent Pkg change lets us fake it, but you're absolutely right we should include a few more helper files. Looks like PkgTemplates might need some new features...

timholy added a commit that referenced this issue Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants