Require method ownership #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on poking around Julia's `src/dump.c`, it's my understanding that a *disconnected* (backedge-free) `MethodInstance` needs to be cached in the module owning the `Method`. The implication is that Base methods that get called on package-defined objects cannot be cached on their own merits, so we should exclude such `MethodInstance`s. The way to fix this is to make such calls inferrable, in which case they will be cached in the package module thanks to their backedges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on poking around Julia's
src/dump.c, it's my understandingthat a disconnected (backedge-free)
MethodInstanceneeds to becached in the module owning the
Method.The implication is that Base methods that get called on
package-defined objects cannot be cached on their own merits, so we
should exclude such
MethodInstances.The way to fix this is to make such calls inferrable,
in which case they will be cached in the package module thanks to
their backedges.