-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module_roots
#157
Add module_roots
#157
Conversation
`module_roots` makes it easier to discover precompile-worthy MethodInstances. The promise of `@snoopi_deep` is that it is not restricted to just the entrance calls to inference; consequently, we can find the most-expensive-to-infer calls in a specific module and precompile those calls.
1b12660
to
06a5526
Compare
@NHDaly, if we were to generate some sort of "latency report and amelioration plan" for users & developers, here are the pieces I'm envisioning in very rough terms:
When you get a chance, I would love a review on this PR, and subsequently #159, so we can get the API moving towards completion. |
I'm just going to start merging these, likely after taking another pass at reworking them. |
I suspect this was superseded by #168, but I'll leave it here for a while at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic documentation additions! :)
But also almost certainly unnecessary! #168 has more powerful functionality. We need to add docs, but I am still feeling my way forward. If you've not seen it, check out the new |
Yeah, this isn't really necessary after #168. |
module_roots
makes it easier to discover precompile-worthyMethodInstances. The promise of
@snoopi_deep
is that it is notrestricted to just the entrance calls to inference; consequently,
we can find the most-expensive-to-infer calls in a specific module and
precompile those calls.
We may want to rewrite the entire
parcel
infrastructure around this, but perhaps one step at a time. We might want to create some kind of aggregate report that combines analysis of excessive specialization, inference breaks, and an improved set of precompile statements.