Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SnoopCompile compatible with JET@0.6.0 #281

Merged
merged 1 commit into from
Jul 5, 2022
Merged

make SnoopCompile compatible with JET@0.6.0 #281

merged 1 commit into from
Jul 5, 2022

Conversation

aviatesk
Copy link
Collaborator

@aviatesk aviatesk commented Jul 5, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #281 (0e6484a) into master (644081f) will decrease coverage by 3.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   86.44%   82.52%   -3.93%     
==========================================
  Files          16       16              
  Lines        2022     1917     -105     
==========================================
- Hits         1748     1582     -166     
- Misses        274      335      +61     
Impacted Files Coverage Δ
src/invalidation_and_inference.jl 0.00% <0.00%> (-87.94%) ⬇️
SnoopCompileCore/src/snoopi.jl 55.73% <0.00%> (-6.09%) ⬇️
src/invalidations.jl 86.11% <0.00%> (-2.38%) ⬇️
src/parcel_snoopi_deep.jl 88.21% <0.00%> (-1.35%) ⬇️
src/deep_demos.jl 57.89% <0.00%> (-1.08%) ⬇️
src/write.jl 91.30% <0.00%> (-1.01%) ⬇️
src/parcel_snoopl.jl 89.47% <0.00%> (-0.53%) ⬇️
SnoopCompileCore/src/snoopi_deep.jl 91.66% <0.00%> (-0.34%) ⬇️
src/parcel_snoopi.jl 93.83% <0.00%> (-0.31%) ⬇️
src/visualizations.jl 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644081f...0e6484a. Read the comment docs.

@aviatesk
Copy link
Collaborator Author

aviatesk commented Jul 5, 2022

The failures in nightly seems to come from the changes on Julia Base from JuliaLang/julia#45069. The integration with JET runs successfully.

@aviatesk aviatesk merged commit 8a29edd into master Jul 5, 2022
@aviatesk aviatesk deleted the avi/jet branch July 5, 2022 14:48
@timholy
Copy link
Owner

timholy commented Jul 22, 2022

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants