Skip to content

Commit

Permalink
[Bug fix] Resolving key conflicts in Timeseries Annotation Layer when…
Browse files Browse the repository at this point in the history
… key is a string (apache#4768)

* Fix how the annotation layer interpretes the timestamp string without timezone info; use it as UTC

* [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data

* [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data

* Fixed indentation

* Fix the key string value in case series.key is a string

* Fix the key string value in case series.key is a string
  • Loading branch information
EvelynTurner authored and timifasubaa committed May 31, 2018
1 parent b2d32b1 commit 0b43714
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion superset/assets/visualizations/nvd3_vis.js
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ function nvd3Vis(slice, payload) {
return {};
}
const key = Array.isArray(series.key) ?
`${a.name}, ${series.key.join(', ')}` : a.name;
`${a.name}, ${series.key.join(', ')}` : `${a.name}, ${series.key}`;
return {
...series,
key,
Expand Down

0 comments on commit 0b43714

Please sign in to comment.