Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackage release is incomplete #9

Closed
mdorman opened this issue Mar 4, 2015 · 3 comments
Closed

Hackage release is incomplete #9

mdorman opened this issue Mar 4, 2015 · 3 comments

Comments

@mdorman
Copy link

mdorman commented Mar 4, 2015

I was just trying to build this on NixOS, and it complained about modules being missing when it tried to build the test suite...and sure enough, if you browse the tarball on hackage, the only thing included in test/ is TestSuite.hs

http://hackage.haskell.org/package/aeson-schema-0.3.0.0/src/test/

mdorman added a commit to mdorman/nixpkgs that referenced this issue Mar 13, 2015
For some reason the .tar.gz on hackage is missing most of the files for
the test suite.  I've opened an issue on
it (timjb/aeson-schema#9), but it's not yet
been acted on.  In the meantime, simply disabling the test suite seems
most sensible.

@peti, could you merge this?
@snoyberg
Copy link

snoyberg commented Apr 2, 2015

Came here to report the same problem from the Stackage side:

Test suite tests: RUNNING...
Data.Aeson.Schema.Types:
  parse schema.json: [Failed]
ERROR: examples/schema.json: openBinaryFile: does not exist (No such file or directory)
  Foldable instance: [OK]
Data.Aeson.Schema.Validator:
  patternProperties: [OK]
  additionalProperties: [OK]
  disallow: [OK]
  type: subschema: [OK]
  dependencies: [OK]
  extends: [OK]
  $ref: [OK]
  divisibleBy.json: divisibleBy validation:
    zero is divisible by anything (except 0): [OK]
    4.5 is divisible by 1.5: [OK]
    35 is not divisible by 1.5: [OK]
  minLength.json: minLength validation:
    longer is valid: [OK]
    exact length is valid: [OK]
    too short is invalid: [OK]
  minItems.json: minItems validation:
    longer is valid: [OK]
    exact length is valid: [OK]
    too short is invalid: [OK]
  enum.json: simple enum validation:
    one of the enum is valid: [OK]
    something else is invalid: [OK]
  enum.json: heterogeneous enum validation:
    one of the enum is valid: [OK]
    something else is invalid: [OK]
    objects are deep compared: [OK]
  properties.json: object properties validation:
    both properties present and valid is valid: [OK]
    one property invalid is invalid: [OK]
    both properties invalid is invalid: [OK]
    doesn't invalidate other properties: [OK]
  items.json: a schema given for items:
    valid items: [OK]
    wrong type of items: [OK]
  items.json: an array of schemas for items:
    correct types: [OK]
    wrong types: [OK]
  additionalItems.json: additionalItems as schema:
    additional items match schema: [OK]
    additional items do not match schema: [OK]
  additionalItems.json: items is schema, no additionalItems:
    all items match schema: [OK]
  additionalItems.json: array of items with no additionalItems:
    no additional items present: [OK]
    additional items are not permitted: [OK]
  additionalItems.json: additionalItems as false without items:
    items should allow anything: [OK]
  maximum.json: maximum validation:
    below the maximum is valid: [OK]
    above the maximum is invalid: [OK]
  maximum.json: exclusiveMaximum validation:
    below the maximum is still valid: [OK]
    boundary point is invalid: [OK]
  minimum.json: minimum validation:
    above the minimum is valid: [OK]
    below the minimum is invalid: [OK]
  minimum.json: exclusiveMinimum validation:
    above the minimum is still valid: [OK]
    boundary point is invalid: [OK]
  maxItems.json: maxItems validation:
    shorter is valid: [OK]
    exact length is valid: [OK]
    too long is invalid: [OK]
  type.json: integer type matches integers:
    an integer is an integer: [OK]
    a float is not an integer: [OK]
    a string is not an integer: [OK]
    an object is not an integer: [OK]
    an array is not an integer: [OK]
    a boolean is not an integer: [OK]
    null is not an integer: [OK]
  type.json: number type matches numbers:
    an integer is a number: [OK]
    a float is a number: [OK]
    a string is not a number: [OK]
    an object is not a number: [OK]
    an array is not a number: [OK]
    a boolean is not a number: [OK]
    null is not a number: [OK]
  type.json: string type matches strings:
    1 is not a string: [OK]
    a float is not a string: [OK]
    a string is a string: [OK]
    an object is not a string: [OK]
    an array is not a string: [OK]
    a boolean is not a string: [OK]
    null is not a string: [OK]
  type.json: object type matches objects:
    an integer is not an object: [OK]
    a float is not an object: [OK]
    a string is not an object: [OK]
    an object is an object: [OK]
    an array is not an object: [OK]
    a boolean is not an object: [OK]
    null is not an object: [OK]
  type.json: array type matches arrays:
    an integer is not an array: [OK]
    a float is not an array: [OK]
    a string is not an array: [OK]
    an object is not an array: [OK]
    an array is not an array: [OK]
    a boolean is not an array: [OK]
    null is not an array: [OK]
  type.json: boolean type matches booleans:
    an integer is not a boolean: [OK]
    a float is not a boolean: [OK]
    a string is not a boolean: [OK]
    an object is not a boolean: [OK]
    an array is not a boolean: [OK]
    a boolean is not a boolean: [OK]
    null is not a boolean: [OK]
  type.json: null type matches only the null object:
    an integer is not null: [OK]
    a float is not null: [OK]
    a string is not null: [OK]
    an object is not null: [OK]
    an array is not null: [OK]
    a boolean is not null: [OK]
    null is null: [OK]
  type.json: any type matches any type:
    any type includes integers: [OK]
    any type includes float: [OK]
    any type includes string: [OK]
    any type includes object: [OK]
    any type includes array: [OK]
    any type includes boolean: [OK]
    any type includes null: [OK]
  type.json: multiple types can be specified in an array:
    an integer is valid: [OK]
    a string is valid: [OK]
    a float is invalid: [OK]
    an object is invalid: [OK]
    an array is invalid: [OK]
    a boolean is invalid: [OK]
    null is invalid: [OK]
  type.json: types can include schemas:
    an integer is invalid: [OK]
    a string is invalid: [OK]
    a float is invalid: [OK]
    an object is valid: [OK]
    an array is valid: [OK]
    a boolean is invalid: [OK]
    null is invalid: [OK]
  type.json: when types includes a schema it should fully validate the schema:
    an integer is valid: [OK]
    an object is valid only if it is fully valid: [OK]
    an object is invalid otherwise: [OK]
  type.json: types from separate schemas are merged:
    an integer is invalid: [OK]
    a string is valid: [OK]
    an array is valid: [OK]
  maxLength.json: maxLength validation:
    shorter is valid: [OK]
    exact length is valid: [OK]
    too long is invalid: [OK]
  uniqueItems.json: uniqueItems validation:
    unique array of integers is valid: [OK]
    non-unique array of integers is invalid: [OK]
    unique array of objects is valid: [OK]
    non-unique array of objects is invalid: [OK]
    unique array of nested objects is valid: [OK]
    non-unique array of nested objects is invalid: [OK]
    unique array of arrays is valid: [OK]
    non-unique array of arrays is invalid: [OK]
  uniqueItems.json: heterogeneous enum validation:
    one of the enum is valid: [OK]
    something else is invalid: [OK]
    objects are deep compared: [OK]
  patternProperties.json: patternProperties validates properties matching a regex:
    a single valid match is valid: [OK]
    multiple valid matches is valid: [OK]
    a single invalid match is invalid: [OK]
    multiple invalid matches is invalid: [OK]
  patternProperties.json: multiple simulatneous patternProperties are validated:
    a single valid match is valid: [OK]
    a simultaneous match is valid: [OK]
    multiple matches is valid: [OK]
    an invalid due to one is invalid: [OK]
    an invalid due to the other is invalid: [OK]
    an invalid due to both is invalid: [OK]
  pattern.json: pattern validation:
    a matching pattern is valid: [OK]
    a non-matching pattern is invalid: [OK]
  required.json: required validation:
    present required property is valid: [OK]
    non-present required property is invalid: [OK]
  required.json: required default validation:
    not required by default: [OK]
  required.json: required explicitly false validation:
    not required if required is false: [OK]
  additionalProperties.json: additionalProperties being false does not allow other properties:
    no additional properties is valid: [OK]
    an additional property is invalid: [OK]
  additionalProperties.json: additionalProperties allows a schema which should validate:
    no additional properties is valid: [OK]
    an additional valid property is valid: [OK]
    an additional invalid property is invalid: [OK]
  additionalProperties.json: additionalProperties are allowed by default:
    additional properties are allowed: [OK]
  format.json: validation of regular expressions:
    a valid regular expression: [OK]
    a regular expression with unclosed parens is invalid: [OK]

         Test Cases    Total        
 Passed  161           161          
 Failed  1             1            
 Total   162           162          
Test suite tests: FAIL
Test suite logged to: /media/87e1532c-61c5-447b-b536-90f764fa12ac/tmp-stackage/logs/stackage-nightly-2015-04-02/aeson-schema-0.3.0.2/test-run.out

snoyberg added a commit to commercialhaskell/stackage that referenced this issue Apr 2, 2015
@timjb
Copy link
Owner

timjb commented Apr 2, 2015

I've added the missing file in 0.3.0.3.

snoyberg added a commit to commercialhaskell/stackage that referenced this issue Apr 2, 2015
@snoyberg
Copy link

snoyberg commented Apr 2, 2015

Thanks for the fast response, Stackage bound relaxed. If there are further issues with the build I just went through I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants