-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 7.29 map and minimap assets. #48
Conversation
Awesome! That sounds like a good approach. The 7.23 images originated from the Dota 2 wiki on Gamepedia. Is that the case for these files too? |
These files I generated. Devilesk (the original person who would generate the map) left some great instructions for the process. I took the old map and lined up fountains (to make sure structures placed correctly) and then double checked their placement with a current replay. |
Ah excellent! If you like we can add a note to the README that you are the creator of these assets specifically. One minor thing: it seems Husky did not enforce commit messages to adhere to the guidelines for you, would you like to change your commit message? Alternatively, I might be able to do that in the merge/squash process. |
Sure thing, that would be great :) Sorry about that. Looking now I see that I don't have the HUSKY_GIT_PARAMS var defined anywhere. Is there a missing .env sample file? After we sort this out I'd be happy to work up a contributors guide as well. |
These git hooks should in theory have installed themselves automatically on At least they do here on my end:
Edit: Just to double check, it's Husky 4 being installed on your end? Husky 7 seems to have changed the way commands/hooks are defined. |
Ahh ok, that was my bad. Needed to have git installed on the docker image. It did take me far too long to think of looking at a prior commit for how to structure the message but it's installed and verified working. Thanks! |
Ah, that makes sense! No worries, I'll have a look. |
Thanks! If you would like to be credited in the README in a certain way, feel free to open a PR for that. Otherwise I'll do that a bit later this week. |
Added the resource note to the README in 051749c. |
Co-authored-by: Bryce Leo <bryce.leo@trainingvault.us>
Nothing fancy here just added the 7.29 assets.
I figure it makes sense to switch to the current patch maps and then back-port older-maps with the pick by date.
If you'd rather not go that route just decline the request and then I'll remove it.