Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding upload path by widget argument #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-thielen
Copy link

I added an optional argument to PageDownWidget named upload_dir. If it is set, IMAGE_UPLOAD_PATH and IMAGE_UPLOAD_UNIQUE are ignored and the provided path is used instead. Like IMAGE_UPLOAD_PATH, upload_dir is inserted between MEDIA_ROOT and the image file name.

If upload_dir is used, the file input element gets a new attribute "data-upload-dir-override" which is added to the POST data by the JavaScript submit handler.

I also added a function that creates a unique file name for the uploaded image. This kind of overlapped with the IMAGE_UPLOAD_UNIQUE feature, but I like my solution better since UUID paths are very bulky. make_unique_path is only called if the upload_dir parameter is used.

If you like it, I can update your README, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant