Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_reading_color_palette: specify colormode #41

Merged
merged 1 commit into from
Jul 4, 2020

Conversation

keturn
Copy link
Contributor

@keturn keturn commented Jan 5, 2020

This test was failing locally for me:

>       assert str(colorful.myBlack) == '\033[30m'
E       AssertionError: assert '\x1b[38;2;0;0;0m' == '\x1b[30m'

I assume because the colormode it detected here was different than the colormode when the assertion was written.

It had a skip condition on it to require a tty, but I'm guessing that was a copy-paste and terminal detection was not supposed to be part of the palette-reading test.

palette reading does not depend on terminal detection
@timofurrer timofurrer merged commit 123b97a into timofurrer:master Jul 4, 2020
@timofurrer
Copy link
Owner

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants