Fix generated create() method for speed optimized code

timostamm · Aug 31, 2021 · 0534891 · 0534891
1 parent 92c42c0
commit 0534891
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 none
 
+Bug fixes:
+
+- Generated `create()` method for speed optimized code got left behind in #55  
+  Thanks to @odashevskii-plaid for the find!
+
 
 ### v2.0.2
 

diff --git a/packages/plugin/src/code-gen/message-type-generator.ts b/packages/plugin/src/code-gen/message-type-generator.ts
@@ -115,6 +115,7 @@ export class MessageTypeGenerator extends GeneratorBase {
         // "MyMessage$Type" members for optimized binary format
         if (optimizeFor === OptimizeMode.SPEED) {
             classDecMembers.push(
+                ...this.typeMethodCreate.make(source, descriptor),
                 ...this.typeMethodInternalBinaryRead.make(source, descriptor),
                 ...this.typeMethodInternalBinaryWrite.make(source, descriptor),
             );

diff --git a/packages/plugin/src/message-type-extensions/create.ts b/packages/plugin/src/message-type-extensions/create.ts
@@ -51,7 +51,7 @@ export class Create implements CustomMethodGenerator {
     makeMethod(source: TypescriptFile, descriptor: DescriptorProto, ...bodyStatements: readonly ts.Statement[]): ts.MethodDeclaration {
         const
             MessageInterface = this.imports.type(source, descriptor),
-            PartialMessage = this.imports.name(source,'PartialMessage', this.options.runtimeImportPath)
+            PartialMessage = this.imports.name(source,'PartialMessage', this.options.runtimeImportPath, true)
         ;
         return ts.createMethod(undefined, undefined, undefined, ts.createIdentifier("create"), undefined, undefined,
             [