Avoid overwriting a set oneof field in target with an unset oneof fie…

…ld in source (#395)
timostamm · Nov 15, 2022 · 0d229dc · 0d229dc
1 parent aa9dc2c
commit 0d229dc
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/runtime/src/reflection-merge-partial.ts b/packages/runtime/src/reflection-merge-partial.ts
@@ -37,7 +37,7 @@ export function reflectionMergePartial<T extends object>(info: MessageInfo, targ
 
         if (field.oneof) {
             const group = input[field.oneof] as UnknownOneofGroup | undefined; // this is the oneof`s group in the source
-            if (group == undefined) { // the user is free to omit
+            if (group?.oneofKind == undefined) { // the user is free to omit
                 continue; // we skip this field, and all other members too
             }
             fieldValue = group[name]; // our value comes from the the oneof group of the source