#57

- honor reserved names
timostamm · Jan 30, 2021 · fb86982 · fb86982
1 parent 63c82d0
commit fb86982
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/packages/plugin/src/interpreter.ts b/packages/plugin/src/interpreter.ts
@@ -228,7 +228,14 @@ export class Interpreter {
 
     private static createTypescriptNameForMethod(descriptor: MethodDescriptorProto): string {
         let escapeCharacter = '$';
-        let reservedClassProperties = ["__proto__", "toString", "name", "constructor", "methods", "typeName", "options", "_transport"];
+        let reservedClassProperties = [
+            // js built in
+            "__proto__", "toString", "name", "constructor",
+            // generic clients
+            "methods", "typeName", "options", "_transport",
+            // @grpc/grpc-js clients
+            "close", "getChannel", "waitForReady", "makeUnaryRequest", "makeClientStreamRequest", "makeServerStreamRequest", "makeBidiStreamRequest"
+        ];
         let name = descriptor.name;
         assert(name !== undefined);
         name = rt.lowerCamelCase(name);