ref Object from globalThis in speed-optimized code for serializing map fields #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
changed the title
|
Released in v2.9.2. |
This was referenced May 24, 2024
This was referenced Jul 19, 2024
This was referenced Jul 26, 2024
This was referenced Aug 10, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #610
The generated code references the global
Object(e.g.Object.keys) without explicitly referencing 'globalThis.' Therefore, if there is a message named 'Object,' issue arises due to incorrect reference (see details at #610). I modified it to accessObjectthroughglobalThis.