Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycode(16) returns up-arrow symbol instead of 'shift' #15

Closed
greim opened this issue Feb 3, 2015 · 2 comments
Closed

keycode(16) returns up-arrow symbol instead of 'shift' #15

greim opened this issue Feb 3, 2015 · 2 comments

Comments

@greim
Copy link
Collaborator

greim commented Feb 3, 2015

A workaround is possible but code like this is no longer possible:

var pressed = keycode(ev);
if ('shift' === pressed) {
  // do something
}

I can provide a PR later if needed. Re-ordering the codes object literal ought to fix it.

@timoxley
Copy link
Owner

timoxley commented Feb 3, 2015

Yep, I think that's the only solution that will have most minor break to compatibility

@timoxley
Copy link
Owner

timoxley commented Feb 3, 2015

Solved in #16.

@timoxley timoxley closed this as completed Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants