De-dupe alias and code objects. (Fixes #15) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved dupe codes from `codes` to `aliases`. Removed things from `aliases` that were already in `codes`. Added a test for common modifier keys.
|
Nice one, these are the exact changes I was thinking. @greim Do you think maybe |
|
cc @yoshuawuyts |
|
Ideally names would all be platform-agnostic. For example 'meta' would be the canonical name, and aliased to 'windows' and 'command'. https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent.metaKey Unless there are actual conflicting mappings I don't think platform-specific mappings would be very useful for my purposes at least. |
|
Released in 2.0.0: 1.0.1...2.0.0 While this change is fairly minor, I've bumped major version as someone could be relying on the old names/aliases export. |
|
Thanks a lot! |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: #15
I think the main back-compat impact is that the mac-specific symbols introduced in #13 are now no longer reverse-mapped into
namesas the canonical name which seemed like it would break on non-mac platforms. However, those symbols are still present incodesso forward lookup for those symbols should still work.