UMD-compatible structure #98
Conversation
|
That's great, thanks so much! 🎉 How close is everyone being happy with this being v2, and releasing this to take it out of beta? |
There was a problem hiding this comment.
Overall I'm not a fan to remove the development server and release helper tasks defined in Gruntfile without alternative solution. The scope of this PR should be to enable UMD support without removing the current development and release workflow. Also we need to make sure the Uglify settings are not lost.
|
|
||
| // default task for developers to start coding | ||
| grunt.registerTask("default", ["connect:dev", "watch"]); | ||
| }; |
There was a problem hiding this comment.
Removing the Gruntfile removes valuable development helpers, release helpers and the special uglify config which raises minified size. I'd rather keep the Gruntfile and invoke Rollup from there.
| //</editor-fold> | ||
|
|
||
|
|
||
| export const DragDropPolyfill = { |
There was a problem hiding this comment.
Re-export is not really needed.
| velocityFn:( velocity:number, threshold:number ) => number; | ||
| } | ||
|
|
||
| function SetOptions( options:ScrollOptions ):void { |
There was a problem hiding this comment.
Directly export this function rather than have a DragDropPolyfill reexport.
| } | ||
|
|
||
| export const HandleDragImageTranslateOverride:DragImageTranslateOverrideFn = handleDragImageTranslateOverride; |
There was a problem hiding this comment.
Maybe this should get a specific "scroll" related name to avoid conflicts on the global "DragDropPolyfill" namespace.
src/drag-drop-polyfill.ts
Outdated
| // regardless of whether that event was canceled or not. | ||
| //this.dragenter( newTarget, this.currentDropTarget ); | ||
| //this.currentDropTarget = newTarget; | ||
|
|
There was a problem hiding this comment.
the definition of this export wrapper will result in global usage pattern of
/// <reference path="../../src/drag-drop-polyfill.d.ts" />
DragDropPolyfill.DragDropPolyfill.Initialize();Rather just export the Initialize() function to get global usage like
/// <reference path="../../src/drag-drop-polyfill.d.ts" />
DragDropPolyfill.Initialize();Module usage
import {Initialize} from "drag-drop-polyfill";
Initialize();or
import {Initialize as DragDropPolyfill} from "drag-drop-polyfill";
DragDropPolyfill();
|
closing in favor of #100 |
Continuing from #87:
The issue is that TypeScript doesn't output UMD modules that are available as browser globals. So instead, this PR uses TypeScript to output ES6 modules which are wrapped up with rollup to produce a UMD module that works everywhere.
I've been using this branch in a TypeScript/WebPack project for a while with no issues.