Set most node_pref settings to indeterminate by default #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings within node_pref should be established with a thorough understanding of the subscription sources' configurations. Additionally, defaulting skip_cert_verify_flag to true exposes security risks. Since pref.example.toml serves as the default configuration file, it is suggested to reset these settings. Also moving us toward Secure-by-Default. Signed-off-by: moexiami <i@f2light.com>
zsokami
pushed a commit
to zsokami/subconverter
that referenced
this pull request
Jun 4, 2024
Settings within node_pref should be established with a thorough understanding of the subscription sources' configurations. Additionally, defaulting skip_cert_verify_flag to true exposes security risks. Since pref.example.toml serves as the default configuration file, it is suggested to reset these settings. Also moving us toward Secure-by-Default. Signed-off-by: moexiami <i@f2light.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings within
node_prefshould be established with a thorough understanding of the subscription sources' configurations.Additionally, defaulting
skip_cert_verify_flagto true exposes security risks.Since
pref.example.tomlserves as the default configuration file, it is suggested to reset these settings. Also moving us toward Secure-by-Default.