IDEA: Set correct module dependencies #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tindzk
force-pushed
the
bug/platform-module-deps
branch
from
6296710 to
09a114d
Compare
tindzk
added a commit
that referenced
this pull request
Sep 3, 2019
Similarly to #52, the generation of compiler profiles for IDEA only honoured Scala options of cross-platform modules. Take the Scala options of platform modules instead. Furthermore, `IdeaFile` used the wrong format to encode Scala options whereby IDEA only picked up custom compiler settings for the first set of modules.
tindzk
force-pushed
the
bug/platform-module-deps
branch
from
09a114d to
171e25d
Compare
tindzk
added a commit
that referenced
this pull request
Sep 3, 2019
Similarly to #52, the generation of compiler profiles for IDEA only honoured Scala options of cross-platform modules. Take the Scala options of platform modules instead. Furthermore, `IdeaFile` used the wrong format to encode Scala options whereby IDEA only picked up custom compiler settings for the first set of modules.
tindzk
force-pushed
the
bug/platform-module-deps
branch
from
171e25d to
36d84a5
Compare
Currently, only module dependencies of cross-platform modules are set when generating an IDEA project. Also include the module dependencies of platform-specific modules. This fixes a regression introduced in 51a27f5.
tindzk
added a commit
that referenced
this pull request
Sep 6, 2019
Similarly to #52, the generation of compiler profiles for IDEA only honoured Scala options of cross-platform modules. Take the Scala options of platform modules instead. Furthermore, `IdeaFile` used the wrong format to encode compiler profiles whereby IDEA only picked up the compiler settings for the first set of modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only module dependencies of cross-platform modules are
set when generating an IDEA project. Also include the module
dependencies of platform-specific modules.
This fixes a regression introduced in 51a27f5.