Updates logr, zapr, packet logr, bmclib dependencies #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/go-logr/logr v0.4.0 -> v1.2.2 github.com/go-logr/zapr v0.4.0 -> v1.2.2 github.com/bmc-toolbox/bmclib v0.4.14 -> v0.4.16 packethost/pkg/log/logr -> packethost/pkg/log/logr/v2 bmclib updated in this change becuse of the indirect (bmclib v0.4.14) dependency on the on logr v0.4.0. expects PR merge: packethost/pkg#51
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 80.93% 80.50% -0.43%
==========================================
Files 10 10
Lines 472 472
==========================================
- Hits 382 380 -2
- Misses 77 79 +2
Partials 13 13
Continue to review full report at Codecov.
|
|
Hey @joelrebel, would you mind creating this branch in a fork and resubmitting the PR? -- ref |
|
yep, will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logr, zapr, packetlogr, bmclib dependencies updated
github.com/go-logr/logr v0.4.0 -> v1.2.2
github.com/go-logr/zapr v0.4.0 -> v1.2.2
github.com/bmc-toolbox/bmclib v0.4.14 -> v0.4.16
packethost/pkg/log/logr -> packethost/pkg/log/logr/v2
bmclib updated in this change because of the indirect (bmclib v0.4.14) dependency on the on logr v0.4.0.
note:
expects linked PR merged packethost/pkg#51 and tagged with
log/logr/v2.0.0once the linked PR is approved, merged and tagged, go.mod is to be updated to remove the
replacedirective2a4ece9#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R44
Why is this needed
The current logr, zapr, packethost/pkg/logr depend on the older 'beta'
logrpackage,this change updates the logging dependencies to the current latest.
for more information see packethost/pkg#51
How are existing users impacted? What migration steps/scripts do we need?
No impact on existing users identified