Skip to content

[BUG] Fix SklearnTransform to pass inference tests #1105

Closed
1 task done
Mr-Geekman opened this issue Feb 8, 2023 · 1 comment
Closed
1 task done

[BUG] Fix SklearnTransform to pass inference tests #1105

Mr-Geekman opened this issue Feb 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Feb 8, 2023

🐛 Bug Report

According to #1094, SklearnTransform in per-segment mode has problems with working on subset of segments and given uncomprehensive error if new segments are met.

Expected behavior

  • SklearnTransform in per-segment mode works fine on subset of segments.
  • SklearnTransform in per-segment gives understandable error message if new segments are met.

To make this we should fix per-segment mode for SklearnTransform. For example, we can fill unpresent segments with some empty value (may be NaN).

How To Reproduce

Run #1094.

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@Mr-Geekman Mr-Geekman added the bug Something isn't working label Feb 8, 2023
@Mr-Geekman Mr-Geekman added this to the Inference 2.1 milestone Feb 8, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Feb 8, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Feb 8, 2023
@Mr-Geekman Mr-Geekman self-assigned this Feb 8, 2023
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Feb 9, 2023
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board Feb 9, 2023
@Mr-Geekman
Copy link
Contributor Author

Closed by #1107.

@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant