Fix SklearnTransform in per-segment mode to work on subset of segments and raise error on new segments
#1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 9, 2023 12:02
…ed and tests for it, add checking if SklearnTransform meet new segments in per-segment mode and tests for it
Mr-Geekman
changed the title
SklearnTransform in per-segment mode to work on subset of segments and fail on new segmentsSklearnTransform in per-segment mode to work on subset of segments and raise error on new segments
|
🚀 Deployed on https://deploy-preview-1107--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## inference-v2.1 #1107 +/- ##
=================================================
Coverage ? 70.47%
=================================================
Files ? 164
Lines ? 8935
Branches ? 0
=================================================
Hits ? 6297
Misses ? 2638
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
brsnw250
reviewed
Feb 13, 2023
tests/test_transforms/test_math/test_sklearn_transform_interface.py
Outdated
Show resolved
Hide resolved
brsnw250
approved these changes
Feb 14, 2023
1 task
This was referenced Mar 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look at #1105.
Closing issues
Closes #1105.