Fix saving/loading ProphetModel
#1019
Conversation
|
🚀 Deployed on https://deploy-preview-1019--etna-docs.netlify.app |
|
|
||
| self.__dict__.update(local_state) | ||
|
|
||
| if is_fitted: |
There was a problem hiding this comment.
May be we can move model creation logic to _create_model method, i.e. add optional parameter state
There was a problem hiding this comment.
I don't really think that it is a good idea. Now _create_model doesn't know anything about serialization. Just handles creation of model using hyperparameters and processing additional_seasonalities (I added this method mostly because of them).
|
|
||
| self.regressor_columns: Optional[List[str]] = None | ||
|
|
||
| def _create_model(self) -> "Prophet": |
There was a problem hiding this comment.
Add description to the method
tests/test_models/test_prophet.py
Outdated
|
|
||
|
|
||
| def test_setstate_not_fitted(): | ||
| model_1 = _ProphetAdapter() |
There was a problem hiding this comment.
May be leave here only one model for simplicity:
initial_state = model.__getstate__()
new_state = model.__setstate__(model.__getstate__()).__getstate_()
There was a problem hiding this comment.
This test and my variation of this test can work even if __setstate__ does nothing. I fixed it.
Isn't |
# Conflicts: # CHANGELOG.md
Before submitting (must do checklist)
Proposed Changes
Look #1016.
Closing issues
Closes #1016.