Forecast decomposition for TBATS #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1133--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1133 +/- ##
==========================================
+ Coverage 86.90% 86.99% +0.08%
==========================================
Files 177 177
Lines 9746 9818 +72
==========================================
+ Hits 8470 8541 +71
- Misses 1276 1277 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
suggested changes
Feb 28, 2023
alex-hse-repository
suggested changes
Mar 1, 2023
|
Also update the changelog |
alex-hse-repository
suggested changes
Mar 3, 2023
| TBATSModel, | ||
| ), | ||
| ) | ||
| def test_seasonal_components_not_fitted(small_periodic_ts, estimator): |
There was a problem hiding this comment.
May you also test the combination of components arma + seasonal if it is a possible scenario
alex-hse-repository
approved these changes
Mar 6, 2023
tests/test_models/test_tbats.py
Outdated
| assert len(components) == horizon | ||
|
|
||
|
|
||
| @pytest.mark.long_2 |
There was a problem hiding this comment.
May you also mark them as long_1 as it takes 10 min for long_2 and 4 min for long_1
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #1125