Make outliers transforms fail on new segments with understandable error #1139
Conversation
|
🚀 Deployed on https://deploy-preview-1139--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## inference-v2.1 #1139 +/- ##
=================================================
Coverage ? 87.01%
=================================================
Files ? 164
Lines ? 8986
Branches ? 0
=================================================
Hits ? 7819
Misses ? 1167
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -155,6 +155,46 @@ def test_inverse_transform_raise_error_if_not_fitted(transform, outliers_solid_t | |||
| _ = transform.inverse_transform(df=outliers_solid_tsds.df) | |||
There was a problem hiding this comment.
Don't we need to add test for _validate_segments ?
There was a problem hiding this comment.
What kind of test do you expect here? I don't think that testing this private method is necessary. But I test that it works when expected in test_transform_new_segments_fail and test_inverse_transform_new_segments_fail.
Before submitting (must do checklist)
Proposed Changes
Add validation of new segments like in
SklearnTransform.Closing issues
Closes #1112.