Fix outliers transforms on future with gap #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1147--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## inference-v2.1 #1147 +/- ##
=================================================
Coverage ? 87.00%
=================================================
Files ? 164
Lines ? 8997
Branches ? 0
=================================================
Hits ? 7828
Misses ? 1169
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
suggested changes
Mar 3, 2023
etna/transforms/outliers/base.py
Outdated
| @@ -103,7 +103,9 @@ def transform(self, df: pd.DataFrame) -> pd.DataFrame: | |||
| segments = df.columns.get_level_values("segment").unique().tolist() | |||
| self._validate_segments(segments) | |||
| for segment in segments: | |||
| result_df.loc[self.outliers_timestamps[segment], pd.IndexSlice[segment, self.in_column]] = np.NaN | |||
| # to locate only present indices | |||
| index_to_check = result_df.index.intersection(self.outliers_timestamps[segment]) | |||
There was a problem hiding this comment.
May be outliers_timestamps_segment or sth like this
alex-hse-repository
approved these changes
Mar 3, 2023
1 task
This was referenced Mar 21, 2023
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Add intersection before indexation.
Closing issues
Closes #1134.