Skip to content

Fix problem with flake B023 #1252

Merged
merged 3 commits into from
May 3, 2023
Merged

Fix problem with flake B023 #1252

merged 3 commits into from
May 3, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented May 2, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Add checking B023 rule. Fix issues with it.

Closing issues

Closes #782.

@Mr-Geekman Mr-Geekman self-assigned this May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

@github-actions github-actions bot temporarily deployed to pull request May 2, 2023 13:52 Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #1252 (b4359d4) into master (6396851) will increase coverage by 0.00%.
The diff coverage is 20.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   57.50%   57.50%           
=======================================
  Files         186      186           
  Lines       10643    10644    +1     
=======================================
+ Hits         6120     6121    +1     
  Misses       4523     4523           
Impacted Files Coverage Δ
etna/analysis/eda/utils.py 21.42% <0.00%> (ø)
etna/analysis/feature_selection/mrmr_selection.py 32.35% <ø> (ø)
etna/auto/optuna/config_sampler.py 33.33% <25.00%> (+1.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request May 3, 2023 07:21 Inactive
@alex-hse-repository alex-hse-repository self-requested a review May 3, 2023 08:17
@alex-hse-repository alex-hse-repository merged commit fecfef5 into master May 3, 2023
@Mr-Geekman Mr-Geekman deleted the issue-782 branch May 3, 2023 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into B023 flake8-bugbear check ⚠️
3 participants