Skip to content

Fix requirements for ruptures and sqlalchemy #1276

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented May 31, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  • Change requirements for ruptures to be not exact
  • Add requirement for sqlalchemy because new version breaks auto modules

Closing issues

@Mr-Geekman Mr-Geekman self-assigned this May 31, 2023
@Mr-Geekman Mr-Geekman added the enhancement New feature or request label May 31, 2023
@github-actions
Copy link

github-actions bot commented May 31, 2023

@github-actions github-actions bot temporarily deployed to pull request May 31, 2023 10:03 Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #1276 (e853feb) into master (ddf0640) will decrease coverage by 30.99%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           master    #1276       +/-   ##
===========================================
- Coverage   88.01%   57.02%   -30.99%     
===========================================
  Files         186      186               
  Lines       10778    10774        -4     
===========================================
- Hits         9486     6144     -3342     
- Misses       1292     4630     +3338     

see 114 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request May 31, 2023 10:40 Inactive
@Mr-Geekman Mr-Geekman requested a review from martins0n June 1, 2023 07:43
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add changelog

@github-actions github-actions bot temporarily deployed to pull request June 1, 2023 09:20 Inactive
@Mr-Geekman Mr-Geekman merged commit bcb98a6 into master Jun 1, 2023
@Mr-Geekman Mr-Geekman deleted the fix-dependencies-2 branch June 1, 2023 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants