Skip to content

Make in-sample predictions of SARIMAXModel non-dynamic in all cases #812

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jul 22, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #811.

Closing issues

Closes #811.

@Mr-Geekman Mr-Geekman self-assigned this Jul 22, 2022
@github-actions
Copy link

github-actions bot commented Jul 22, 2022

🚀 Deployed on https://deploy-preview-812--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 22, 2022 08:29 Inactive
@martins0n martins0n self-requested a review July 25, 2022 07:46
martins0n
martins0n previously approved these changes Jul 26, 2022
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n enabled auto-merge (squash) July 26, 2022 10:01
@github-actions github-actions bot temporarily deployed to pull request July 26, 2022 10:05 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #812 (7e6362b) into master (4d5adee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         126      126           
  Lines        7237     7237           
=======================================
  Hits         6104     6104           
  Misses       1133     1133           
Impacted Files Coverage Δ
etna/models/sarimax.py 94.11% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@martins0n martins0n merged commit 36dec78 into master Jul 26, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Make in-sample predictions of SARIMAXModel non-dynamic in all cases
3 participants