Skip to content

Fix problem with encoding category types #843

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Fix problem with encoding category types #843

merged 3 commits into from
Aug 11, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Aug 10, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  1. Change the way we select values before passing them into sklearn.
  2. Add tests on str and category dtypes.

Closing issues

Closes #826.

@Mr-Geekman Mr-Geekman self-assigned this Aug 10, 2022
@github-actions
Copy link

github-actions bot commented Aug 10, 2022

🚀 Deployed on https://deploy-preview-843--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request August 10, 2022 08:55 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #843 (08bbd23) into master (910441d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         130      130           
  Lines        7411     7411           
=======================================
  Hits         6274     6274           
  Misses       1137     1137           
Impacted Files Coverage Δ
etna/transforms/encoders/categorical.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@martins0n martins0n self-requested a review August 11, 2022 07:40
@github-actions github-actions bot temporarily deployed to pull request August 11, 2022 08:35 Inactive
@martins0n martins0n merged commit 4c1b713 into master Aug 11, 2022
@martins0n martins0n deleted the issue-826 branch August 11, 2022 13:18
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OneHotEncoder with categorical-float columns
3 participants