Check for ports already in use before connecting to serial port #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I second this PR. Please check and merge. |
|
me too pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I would like to a propose a possible solution to the previously posted issue #100. I am excited for contributing to an open source project for the first time. Please forgive me if proposed solution is incorrect.
Summary of issue and solution:
If a user tries to open a port that is already in use, then
serial.serialutil.SerialExceptionerror will occur. To minimize occurrence of this issue, every time aBoard()object is created, we should check to see if the port was already opened by pyFirmata previously by using a class attribute,_boards_in_usethat keeps track of all serial ports opened by pyFirmata.