Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix themes to support primary search/selection #12

Open
nazarewk opened this issue Apr 16, 2024 · 3 comments
Open

Fix themes to support primary search/selection #12

nazarewk opened this issue Apr 16, 2024 · 3 comments

Comments

@nazarewk
Copy link

I thought it was [something wrong with helix install](see also helix-editor/helix#5309), but looks like numerous upstream themes have this issue too helix-editor/helix#3842 (including default theme).

this seems to be refered to as highlighting for the primary cursor

here seems to be an example fix https://github.com/helix-editor/helix/pull/5573/files

@nazarewk
Copy link
Author

nazarewk commented Apr 16, 2024

actually this is explicitly set to the same as normal selection

"ui.selection" = { bg = "base02" }
"ui.selection.primary" = { bg = "base02" }

it should be different to even go through hx --tutor

@nazarewk
Copy link
Author

another option is distinguishing cursor for selections:

"ui.cursorline" = { bg = "my_gray3" }
"ui.cursorline.primary" = { bg = "my_black" }
"ui.cursorline.secondary" = { bg = "my_black" }

nazarewk added a commit to nazarewk-iac/nix-configs that referenced this issue Apr 16, 2024
addresses helix-editor/helix#3842
might help with tinted-theming/base16-helix#12

Signed-off-by: Krzysztof Nazarewski <gpg@kdn.im>
@JamyGolden
Copy link
Member

@krgn (tagging you since github doesn't auto tag maintainers people on github issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants