Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CHANGELOG.md #87

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Remove CHANGELOG.md #87

merged 1 commit into from
Dec 23, 2023

Conversation

DoctorKrolic
Copy link
Collaborator

This is just a copy of a changelog from the extension repo, meaning it doesn't represent changes actually made to the server side. So it is just a maintance burden to keep it in sync with the extension's changelog with no clear benifits. Morover, currently even though the server is separated from the extension, they are still very much tied together and server changes are motivated only by extension's needs. My idea is to change that when the server becomes a separate thing (#33) and version it separately as well (e.g. starting from 1.0.0), but I don't think we've reached the quality bar for this yet. If that plan comes true though we will have to rewrite the changelog with the respect to new versioning anyway, so it is +1 reason to remove current changelog and not bother copying it every time we release a new extension version

@tintoy
Copy link
Owner

tintoy commented Dec 23, 2023

At one stage, the language server was also being consumed by an Eclipse extension (which is why it had its own change log) but they don’t seem to be consuming it anymore so I guess this change is fine.

@DoctorKrolic DoctorKrolic merged commit 56635f4 into master Dec 23, 2023
1 check passed
@DoctorKrolic DoctorKrolic deleted the remove-server-changelog branch December 23, 2023 18:31
tintoy added a commit that referenced this pull request Dec 24, 2023
tintoy added a commit to tintoy/msbuild-project-tools-vscode that referenced this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants