Switch libwebsockets license link to Github #1727
Conversation
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM, thanks.
We can otherwise also wait a bit to see whether things may eventually settle.
No, I feel like it's already too much of an interruption. I agree we should shift to the more stable mirror.
👀 @jotaen4tinypilot it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: app/license_notice.py:
> Line 206
'https://github.com/warmcat/libwebsockets/blob/v3.2.2/LICENSE',
Can we add a note explaining why we're using Github instead of libwebsockets.org?
👀 @jotaen4tinypilot it's your turn please take a look
mtlynch
changed the title
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: app/license_notice.py:
> Line 211
'https://github.com/warmcat/libwebsockets/blob/v3.2.2/LICENSE',
Resolved
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
The libwebsockets website is down, so our end-to-end tests are currently broken due to that.
This happened one or two times in the past already, and this comment from the libwebsocket maintainer suggests that it might be more reliable for us to use Github for referencing the sources.
We can otherwise also wait a bit to see whether things may eventually settle.
