Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbadisplay: add simple driver for the GameBoy Advance display #620

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented Nov 23, 2023

This only implements the 15 bits per pixel mode, not any of the other possible display modes. This matches conventional SPI displays most closely. Future additions might add more display modes.

Normally I'd argue interfacing with chip/board specific hardware should be done in the machine package using a generic interface, but the GBA is kind of special and I don't want the machine package to depend on the tinygo.org/x/drivers/pixel package.

This only implements the 15 bits per pixel mode, not any of the other
possible display modes. This matches conventional SPI displays most
closely. Future additions might add more display modes.

Normally I'd argue interfacing with chip/board specific hardware should
be done in the machine package using a generic interface, but the GBA is
kind of special and I don't want the machine package to depend on the
tinygo.org/x/drivers/pixel package.
@deadprogram
Copy link
Member

Perhaps this would be better off in the https://github.com/tinygo-org/tinygba repo?

@aykevl
Copy link
Member Author

aykevl commented Nov 24, 2023

Yes, sounds like a good idea. I'll make a PR there.

@aykevl
Copy link
Member Author

aykevl commented Nov 24, 2023

Ok, made a PR for the RGB555 pixel format here: #621

Honestly I just wanted to add the RGB555 pixel format here, so that I could use it with my in-development board package here: https://github.com/aykevl/board/blob/main/board-gameboy-advance.go
I could also make a PR to the tinygba repo with the display, if you like? I'm also fine with keeping everything inside that board package and only adding the RGB555 pixel format.

@deadprogram
Copy link
Member

I could also make a PR to the tinygba repo with the display, if you like?

It seems like a useful thing for people to be able to find, so yes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants